On Wed, Aug 27, 2014 at 12:00 AM, Gisle Vanem <gvanem_at_yahoo.no> wrote:

> "Tatsuhiro Tsujikawa" <tatsuhiro.t_at_gmail.com> wrote:
>
> totally agree with you. Should I include this change to the patch?
>>
>
> Some other trouble I'm fighting with. In include/nghttp2/nghttp2.h the
> comment says:
>
> * Callback functions for :type:`nghttp2_session`. The details of
> * this structure are intentionally hidden from the public API.
> */
> typedef struct nghttp2_session_callbacks nghttp2_session_callbacks;
>
> But then in libcurl's http2.c:
>
> static const nghttp2_session_callbacks callbacks = {
> send_callback, /* nghttp2_send_callback */
> NULL, /* nghttp2_recv_callback */
> ...
>
> -----------
>
> libcurl uses the public API of Nghttp2. So how can this layout be
> "intentionally hidden from the public API." ?
>
>
​Previously, nghttp2's callback struct was public API​. Now it is hidden
and the patch I made in this thread deletes these lines and uses new API
instead of raw struct members.

If you are building curl with latest nghttp2, apply my patch before
building curl.

Best regards,
Tatsuhiro Tsujikawa

> --gv
>
>
> -------------------------------------------------------------------
> List admin: http://cool.haxx.se/list/listinfo/curl-library
> Etiquette: http://curl.haxx.se/mail/etiquette.html
>

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-08-26