cURL / Mailing Lists / curl-library / Single Mail


Re: Patches to make testing external proxies more convenient

From: Daniel Stenberg <>
Date: Tue, 27 May 2014 23:31:43 +0200 (CEST)

On Wed, 21 May 2014, Fabian Keil wrote:

> I'm still doing that and would like to get the required changes
> upstream after making them more generic.

Thanks for keeping it up Fabian. I'm in favor of making sure that the curl
test suite can be re-used for more purposes as I believe it can help improving
more code and it will help the test suite and thus it also improves curl

> I attached some of the patches I'm currently using as examples.

I'm fine with all of them really. My only gripe is that they add functionality
and features not really exposed or exercised by curl itself so there's a big
risk that we ruin this by mistake as we go along.

It would be good to add a test for curl that uses the feature for that reason

> The only Privoxy-specific patch is 0001, to make it generic it should be
> sufficient to add another option to specify an external script to compare()
> the test results with proxy-specific knowledge (currently done inline).

That would indeed be nicer and it would then properly allow you to polish and
improve that script independently of our script.

> Patch 0003 isn't absolutely required and the chosen syntax turned out to be
> flawed

... but you're still proposing we merge it?

List admin:
Received on 2014-05-27