cURL / Mailing Lists / curl-library / Single Mail


[PATCH] openssl: Fix uninitialized variable use in NPN callback

From: Tatsuhiro Tsujikawa <>
Date: Wed, 21 May 2014 23:55:57 +0900


OpenSSL passes out and outlen variable uninitialized to
select_next_proto_cb callback function. If the callback function
returns SSL_TLSEXT_ERR_OK, the caller assumes the callback filled
values in out and outlen and processes as such. Previously, if there
is no overlap in protocol lists, curl code does not fill any values in
these variables and returns SSL_TLSEXT_ERR_OK, which means we are
triggering undefined behavior. valgrind warns this.

This patch fixes this issue by filling HTTP/2 protocol identifier
nghttp2 library supports when there is no overlap. Unlike ALPN, NPN
says that client should select first protocol it supports if there is
no overlap.

Best regards,
Tatsuhiro Tsujikawa

List admin:

Received on 2014-05-21