curl-library
Re: Request to review the code changes for NTLMv2 Support in Curl
From: Colin Hogben <curl_at_pythontech.co.uk>
Date: Wed, 22 Jan 2014 12:00:00 +0000
Date: Wed, 22 Jan 2014 12:00:00 +0000
On 01/21/14 10:58, Prash Dush wrote:
> Kindly review the code changes and provide your valuable feedback.
A couple of things I spotted:
+
+ memcpy(ptr+24, &tw, 8); /*Re-Write this line for Big Endian*/
Then please do so to make the code portable across architectures.
unsigned char ntresp[24]; /* fixed-size */
+ unsigned char *ptr_ntresp = (unsigned char*)&ntresp[0];
The cast is redundant.
-- Colin Hogben ------------------------------------------------------------------- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.htmlReceived on 2014-01-22