cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: [PATCH] OAUTH 2.0 Bearer token support SMTP/IMAP (XOAUTH2)

From: Steve Holme <steve_holme_at_hotmail.com>
Date: Tue, 15 Oct 2013 21:42:46 +0100

On Sat, 12 Oct 2013, Kyle L. Huff wrote:

> > Daniel announced this week that we are approaching feature freeze
> > for cURL 7.33 and as I felt it would be best to add XOAUTH to POP3 in
> > the same release as IMAP and SMTP I have cobbled together the
> > appropriate implementation.
>
> Sorry for the late reply, I've been slammed at work.

No problem.

> > I have pushed this as commit 18db7438512de1 and would appreciate it
> > if you would be so kind to review the code at some point.
>
> I have taken a look, and I don't see any issues.

That's great - thank you very much.

> I did however notice while I was poking around that the option '--bearer'
> might be slightly ambiguous in name.

I see Daniel pushed a quick fix which made it into the 7.33 release - so
thank you again for raising that.

> I don't know enough about the OAUTH v1.0 implementation to say if
> something like "--oauth-bearer" would be a better choice, and of course
> that presumes that there is a possibility that at some point OAUTH v1.0
> will be implemented in cURL I wonder.

I will of course review the work if someone step's up and fancies having a
stab at implementing it ;-)

Kind Regards

Steve
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-10-15