cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: URL parsing

From: Steve Holme <steve_holme_at_hotmail.com>
Date: Fri, 19 Apr 2013 17:13:06 +0100

On Fri, 19 Apr 2013, Tor Arntsen wrote:

> > Would someone be so kind to take a look at parse_login_details() in
> > url.c (specifically the malloc at line 4510) please to see what I have
> > done wrong?
>
> I just did a quick check, no fix, but there is a problem in url.c,
function
> parse_login_details():

Thank you.

> This:
> plen = (psep ?
> (osep && osep > psep ? (size_t)(osep - psep) :
> (size_t)(login + len - psep)) - 1 : 0);

I think the issue is that psep contains the port separator from the hostname
as opposed to a NULL from not finding it in the login details as I'm not
performing any bounds checking.

I'll come up with an appropriate fix - thank you again.

Kind Regards

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2013-04-19