cURL / Mailing Lists / curl-library / Single Mail


[PATCH] remove strlcat

From: Daniel Stenberg <>
Date: Wed, 13 Feb 2013 13:31:30 +0100 (CET)


I noticed we hardly use strlcat and I think things would be cleaner without
it, so that's what this patch is about.

As it is slightly intrusive I thought I'd first run it through the list to see
if there's anyone objecting to this change before I run ahead and push it:

     strlcat: remove function

     This function was only used twice, both in places where performance
     isn't crucial (socks + if2ip). Removing the use of this function removes
     the need to have our private version for systems without it == reduced
     amount of code.

     Also, in the SOCKS case it is clearly better to fail gracefully rather
     than to truncate the results.

     This work was triggered by a bug report on the strlcat prototype in

     strlcat was added in commit db70cd28 in February 2001!

     Reported by: Jeremy Huddleston

12 files changed, 25 insertions(+), 172 deletions(-)


List admin:

Received on 2013-02-13