curl-library
[PATCH] remove strlcat
Date: Wed, 13 Feb 2013 13:31:30 +0100 (CET)
Hello,
I noticed we hardly use strlcat and I think things would be cleaner without
it, so that's what this patch is about.
As it is slightly intrusive I thought I'd first run it through the list to see
if there's anyone objecting to this change before I run ahead and push it:
strlcat: remove function
This function was only used twice, both in places where performance
isn't crucial (socks + if2ip). Removing the use of this function removes
the need to have our private version for systems without it == reduced
amount of code.
Also, in the SOCKS case it is clearly better to fail gracefully rather
than to truncate the results.
This work was triggered by a bug report on the strlcat prototype in
strequal.h.
strlcat was added in commit db70cd28 in February 2001!
Bug: http://curl.haxx.se/bug/view.cgi?id=1192
Reported by: Jeremy Huddleston
12 files changed, 25 insertions(+), 172 deletions(-)
-- / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
- TEXT/x-diff attachment: 0001-strlcat-remove-function.patch