cURL / Mailing Lists / curl-library / Single Mail


Re: [PATCH] always multi v5

From: Daniel Stenberg <>
Date: Thu, 17 Jan 2013 19:40:07 +0100 (CET)

On Thu, 17 Jan 2013, Yang Tse wrote:

> Commit pushed now for
> autobuild testing, solves the problems shown locally with test cases 1059
> and 1316.

> Currently I have no functional pending issues with the 'always multi'
> modification.

Great. I intend to merge my always-multi patch now. Or at least during this
evening. Thanks for all your help with this!

> Two remaining nits would be:
> *) Extract into a different patch the 'non always multi' stuff,
> modification/addition of:
> tests/
> tests/
> tests/valgrind.supp

I thought about that but decided not to. Mostly because the valgrind.supp I
made doesn't apply in this shape without the patch (due to the different code
paths with and without the patch) and I don't think it is worth the effort to
fix it first without the patch only to change it again when the patch is

> *) lib/ftp.c lines 104 and 784 use DEBUGBUILD instead of CURLDEBUG,

Ack, thanks. I'll fix this before I merge.

List admin:
Received on 2013-01-17