cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] always multi v5

From: Yang Tse <yangsita_at_gmail.com>
Date: Thu, 17 Jan 2013 18:23:20 +0100

Commit https://github.com/bagder/curl/commit/9fd88abb pushed now for
autobuild testing, solves the problems shown locally with test cases
1059 and 1316.

The patch has been tested without 'always multi' on top of commit
4ed6b07a, with test suite passing ok.

Additionally, patch tested with 'always multi'...

[1] 'always-multi-v5' applied on top of commit fea3a3d, plus...
[2] 'retry handling patch'

Test suite also passes ok. (Except 238 which now is handled differently [3]).

Currently I have no functional pending issues with the 'always multi'
modification.

Two remaining nits would be:

*) Extract into a different patch the 'non always multi' stuff,
modification/addition of:

 tests/Makefile.am
 tests/runtests.pl
 tests/valgrind.supp

*) lib/ftp.c lines 104 and 784 use DEBUGBUILD instead of CURLDEBUG,

Thanks,

[1] http://curl.haxx.se/mail/lib-2013-01/0108.html
[2] http://curl.haxx.se/mail/lib-2013-01/0170.html
[3] https://github.com/bagder/curl/commit/533c31b7

-- 
-=[Yang]=-
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2013-01-17