On Thu, 22 Nov 2012, Fabian Keil wrote:

> Regarding the documentation I think it would make sense to refer to the
> CURLOPT_HTTPHEADER for the syntax description instead of duplication most of
> it, or at least making it clear that the syntax is basically the same, so
> the user doesn't spend time looking for differences that don't exist.

Ack, fixed now.

> I also believe that "used for proxy requests" could be mistaken to mean
> requests that are made through a proxy, so maybe the documentation should
> explicitly refer to CONNECT requests like the commit description does.

I changed that to become a settting for all HTTP proxy requests, including
non-CONNECT cases. I decided to do this because it struck me it isn't very
easy for an application to otherwise separate headers for proxies and hosts
since libcurl does most of the proxy checking magic itself so many
applications won't know if the request goes out over a proxy or directly to
the server. So the documentation actually describes what the code does.

Obviously I also need to write up a set of test cases to verify that it works.

Attached is an updated version of the patch.

-- 
  / daniel.haxx.se

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html