cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] CURLOPT_PROXYHEADER: send/replace proxy headers only

From: Fabian Keil <freebsd-listen_at_fabiankeil.de>
Date: Thu, 22 Nov 2012 12:21:58 +0100

Daniel Stenberg <daniel_at_haxx.se> wrote:

> On Sat, 8 Sep 2012, Daniel Stenberg wrote:
 
> Here's my first take at a CURLOPT_PROXYHEADER option that should allow an
> application to select to affect only host, proxy or both request headers.
>
> I've not written any test cases yet for this nor pushed this commit, but I
> thought I'd first offer everyone a chance to comment on the concept/idea.

Looks good to me.

Regarding the documentation I think it would make sense to refer
to the CURLOPT_HTTPHEADER for the syntax description instead of
duplication most of it, or at least making it clear that the
syntax is basically the same, so the user doesn't spend time
looking for differences that don't exist.

I also believe that "used for proxy requests" could be mistaken
to mean requests that are made through a proxy, so maybe the
documentation should explicitly refer to CONNECT requests like
the commit description does.

Fabian

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2012-11-22