curl-library
RE: authp->picked not being cleared on failed Negotiate auth
Date: Wed, 18 Jul 2012 13:47:01 +0000
> From: curl-library-bounces_at_cool.haxx.se [curl-library-bounces_at_cool.haxx.se] on
> behalf of Joe Mason [jmason_at_rim.com]
> Sent: Tuesday, July 17, 2012 2:47 PM
> To: curl-library_at_cool.haxx.se
> Subject: authp->picked not being cleared on failed Negotiate auth
>
> So it looks like "picked" should be cleared at some point when Negotiate auth
> fails, so that it doesn't keep trying to use it for further requests. But I'm
> not sure where this is should be done.
I fixed this by resetting picked every time there's an authproblem (see attached patch). My reasoning is that if there was a problem, this auth scheme is no longer in use.
Does this sound like the right approach?
Joe
---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
- text/x-diff attachment: 0001-Reset-authp-picked-whenever-there-s-an-authproblem.patch