cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: curl_schannel.c and realloc()

From: Marc Hoersken <info_at_marc-hoersken.de>
Date: Wed, 13 Jun 2012 23:57:31 +0200

Hi Daniel,

2012/6/13 Daniel Stenberg <daniel_at_haxx.se>:
> On Wed, 13 Jun 2012, Marc Hoersken wrote:
>
>>> I was first going to agree and then a second thought struck me. Why would
>>> it ever need to handle more data? If it gets called asking for 20K of data,
>>> there's nothing in the API that says the function must return that much. We
>>> can safely just make BUFSIZE the maximum amount of data the schannel_recv()
>>> function can return without it breaking any properly written code!
>>>
>>> It would simplify the code without breaking anything...
>>
>>
>> That's a good plan.
>
>
> Would you be able to write up a patch for this? As I don't build for or use
> Windows myself I will only mess up some little detail if I try to write this
> "blindly" ...

yes, of course I will be able to provide a patch for this. But I would
like to give it a little more time until the other SSPI discussions
are settled. Or do you have any other recommendations?

Best regards,
Marc
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2012-06-13