cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Windows SSPI Schannel implementation ready

From: Guenter <lists_at_gknw.net>
Date: Wed, 13 Jun 2012 17:34:28 +0200

Hi,
Am 13.06.2012 16:40, schrieb Yang Tse:
> One of the reasons for which I personally dislike big patches is that
> these usually hide changes which are not properly discussed, or
> discussed with such lengthy threads that no one knows finally what's
> going on, making it necessary to fully analyze resulting patch in
> order to know what changes it really introduces. This is what I'm
> doing now. I might have further objections, so don't be surprised if I
> mention or fix something else.
but then we did make a mistake: we saw this huge patch coming, and it
was then wrong to encorage Marc to work further in his fork until its
ready - instead we should have granted him commit rights and told him to
push his changes one by one right after the last release.

just my 2ct.

GŁn.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2012-06-13