cURL / Mailing Lists / curl-library / Single Mail


Re: PATCH: Do not allow multi interface to block trying to perform DNS on interface names

From: Daniel Stenberg <>
Date: Mon, 12 Dec 2011 23:34:30 +0100 (CET)

On Sun, 11 Dec 2011, Jason Glasgow wrote:

> I've fixed the unused variable and added documentation, but I was hesitant
> to resend the patch until I had added some tests. I have not had time to
> figure out how to test this, though I am hoping to get to it this month.
> Attached is the latest patch with documentation. I understand if you want
> to wait to merge this until I have written some tests for it.

I think writing tests for this will be a bit of a job, as we need to provide a
test version of some underlying functions so that we know what interfaces that
will exist in a given test. Clearly doable, but slightly more work than "just"
writing up a test case using the existing infrastructure.

I think the change looks "harmless" enough to get merged now and we can work
on adding tests later on. I've now pushed it. Thanks!

List admin:
Received on 2011-12-12