On 17/11/11 23:59, Daniel Stenberg wrote:
> On Thu, 17 Nov 2011, Daniel Stenberg wrote:
>
>> That's indeed a good start. Unfortunately we don't test SSL session
>> sharing so it doesn't tell us a very great deal... But reading the
>> code it looks good.
>
> I take that back! ;-/
>
> The age increment was done wrong, the function returned while holding
> the lock and it did a shared lock while still writing to the shared data.
>
> I've done to follow-up commits I believe makes the function work more
> as intended now. I guess it shows we really need tests...
>
Sorry, I missed that. And I think I did in the first patch, actually.
Should be more careful with the returns.

I have added a ticket to our Trac to try and see how to better debug
this. I can not compromise to have it quick, but at least it is noted :)

Regards, and thanks.

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-11-18