cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: SSL session sharing support added to curl_share_setopt()

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 17 Nov 2011 23:59:41 +0100 (CET)

On Thu, 17 Nov 2011, Daniel Stenberg wrote:

> That's indeed a good start. Unfortunately we don't test SSL session sharing
> so it doesn't tell us a very great deal... But reading the code it looks
> good.

I take that back! ;-/

The age increment was done wrong, the function returned while holding the lock
and it did a shared lock while still writing to the shared data.

I've done to follow-up commits I believe makes the function work more as
intended now. I guess it shows we really need tests...

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-11-18