cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Added AUTH NTLM for SMTP

From: Yang Tse <yangsita_at_gmail.com>
Date: Mon, 8 Aug 2011 19:52:41 +0200

2011/8/8 Steve Holme wrote:

> Do you have a specific example in mind as I am very confused now?

i.e...

In http_ntlm.c

1) DEBUG_OUT macro definition.
2) renaming of print_flags() and print_hex().
3) a couple of places where you appropiately introduce and use vars
domlen, userlen, passwdlen.
4) your appropiate reformatting of code when calling
s_pSecFn->AcquireCredentialsHandleA().
5) your reformatting of "if(status == SEC_I_COMPLETE_AND_CONTINUE ||
status == SEC_I_CONTINUE_NEEDED)" does not need parenthesis on the
'if' branch.
6) Your appropiate reformatting of several function calls snprintf()
LONGQUARTET() and fprint() among them.

All of the above can merrily be done in a first patch of the first
step, which won't disturb existing functionality.

Remember that we are aiming at no reformatting allowed for the second step.

-- 
-=[Yang]=-
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2011-08-08