Hi Yang,

On Mon, 8 Aug 2011, Yang Tse wrote:

> No. With this I meant changes to http_ntlm.c and http_ntlm.h that your
patch
> seems to introduce, that I suppose you deem necessary for NTLM correctness
> or convinience and that can be performed on existing code without the need
to
> moving it out of those two files.

Do you have a specific example in mind as I am very confused now?

The main changes in these files were: The removal of the ntlm / crypto code
to curl_ntlm, the modification of Curl_output_ntlm() and Curl_input_ntlm()
to call the functions in curl_ntlm (instead of having the message encode /
decode code embedded in them), plus a small tidy up and refactor of
Curl_ntlm_cleanup() to Curl_http_ntlm_cleanup() as I had written a
Curl_ntlm_cleanup() in curl_ntlm.

> The smtp and mail stuff would belong to the third step.

No problem.

> It is easy break this phase into two different patches, one the does the
refactoring without actually adding nor changing functionality, and a second
one that brings in the new stuff.

Not really - As I mentioned above only one function in http_ntlm was
refactored. All the other mods were related to code moving and then being
fixed up to work as standalone functions whilst making sure the Windows SPPI
code worked as well.

Kind Regards

Steve

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2011-08-08