On Sun, 19 Jun 2011, Amr Shahin wrote:

> Thanks folks, attached is the updated patch.

Thanks, committed!

> Any suggestion for good unit test candidates ?

There are still 90(!) source files without a single function being unit
tested[*].

Possible good file candidates with funtions to test include: mprintf.c,
hmac.c, md5.c, md4.c, select.c, slist.c, strtoofft.c, strtok.c and more.

[*] = I wrote this little shell script to get a quick view:

#!/bin/sh
grep -l @unittest *.c > /tmp/tested
ls -1 *.c > /tmp/all

sort /tmp/tested /tmp/all | uniq -u

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html