On Thursday 12 August 2010 23:24:05 Michal Marek wrote:
> On 12.8.2010 20:59, Kamil Dudka wrote:
> > attached is a patch that eliminates compiler warnings with gcc
> > 4.3.x/4.4.x when -Wlogical-op is given, as suggested by Eric Blake
> > (CC'd). Note the problem is no longer reproducible with gcc 4.5+. More
> > details are at our bugzilla:
> >
> > https://bugzilla.redhat.com/617757
> >
> > Could you please have a look if the workaround is acceptable and
> > harmless? Thanks in advance!
>
> I have gcc-4.5 so I could not reproduce the gcc warning, but the patch
> looks correct and works correctly. Thanks for looking into this!

Thanks for review! Pushed as a6e088e, additionally with a tiny comment
that explains why two 'if' statements instead of &&.

> PS: git diff --color-words really help reviewing search and replace type
> of patches.

Indeed, it seems quite useful.

Kamil
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-08-13