On 12.8.2010 20:59, Kamil Dudka wrote:
> attached is a patch that eliminates compiler warnings with gcc 4.3.x/4.4.x
> when -Wlogical-op is given, as suggested by Eric Blake (CC'd). Note the
> problem is no longer reproducible with gcc 4.5+. More details are at our
> bugzilla:
>
> https://bugzilla.redhat.com/617757
>
> Could you please have a look if the workaround is acceptable and harmless?
> Thanks in advance!

I have gcc-4.5 so I could not reproduce the gcc warning, but the patch
looks correct and works correctly. Thanks for looking into this!

Michal

PS: git diff --color-words really help reviewing search and replace type
of patches.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2010-08-12