cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] FTP WILDCARDMATCH option (only for now)

From: Pavel Raiskup <xraisk00_at_gmail.com>
Date: Wed, 12 May 2010 16:47:07 +0200

>> Here is new wildcardmatch attempt!
>
> Lovely, now we're getting really close!
>
>> `git am --keep-cr 0001- .. .patch'
>
> This didn't work since there's been another test case added that
> collides: 573. Can you rename your 573 to 577 or something and submit?

Test moved 573 => 577.

> A little nitpick that isn't really preventing an initial commit as it
> can easily be changed afterwards: I'm not sure I like the ADDHCAR() and
> REMCHAR() macros in curl_fnmatch.c instead of using the actual code
> which is still very small and makes the code easier to follow.

Macros removed substituted.

Edited man pages and some comments in English (Thanks Kamil).

Pavel
Received on 2010-05-12