cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] FTP WILDCARDMATCH option (only for now)

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 12 May 2010 10:20:47 +0200 (CEST)

On Fri, 7 May 2010, Pavel Raiskup wrote:

> Here is new wildcardmatch attempt!

Lovely, now we're getting really close!

> `git am --keep-cr 0001- .. .patch'

This didn't work since there's been another test case added that collides:
573. Can you rename your 573 to 577 or something and submit?

A little nitpick that isn't really preventing an initial commit as it can
easily be changed afterwards: I'm not sure I like the ADDHCAR() and REMCHAR()
macros in curl_fnmatch.c instead of using the actual code which is still very
small and makes the code easier to follow.

Thanks for your hard work!

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2010-05-12