cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH, RFC] Make hostthre.c work on POSIX

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 25 Sep 2009 13:22:53 +0200 (CEST)

On Thu, 24 Sep 2009, Joshua Kwan wrote:

> So we chose to drop c-ares on Mac OS X and instead do what is done for
> Windows in hostthre.c: do a threaded getaddrinfo() resolve. To this end, I
> genericized the code in hostthre.c to be compilable on both Windows and Mac,
> by using macros to abstract away the competing threading idioms. (Despite
> certain wrinkles, they are actually quite similar.)
>
> The code now compiles and works properly on OS X and reasonably modern
> Linuxes with pthreads. Additionally, I've reworked the configure script so
> that it will choose threaded resolve when pthreads are available but c-ares
> is not. I've also regression tested the whole thing on Windows XP and above.

Nice work!

I've nothing against adding another name resolving approach as you describe,
as long as it doesn't get "accidentally" enabled by users who thought
otherwise.

As I said in a pervious mail, the exact procedure to get this merged should
get coordinated with Constantine Sapuntzakis and his win32-related fixes of
that same threaded-resolver functionality.

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Received on 2009-09-25