cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: "100% CPU usage during SFTP transfer" bugfix

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 21 Aug 2009 14:16:30 +0200 (CEST)

On Fri, 21 Aug 2009, Daniel Stenberg wrote:

>> I am still a bit new to libcurl and not yet familiar with its design. What
>> about not making 'waitfor' as ssh-specific? Then its value can be checked
>> within Curl_readwrite() and performed the appropriate poll if necessary,
>> not sure how is the situation with other protocols...
>
> Yes, that's along my line of thinking. We must of course make sure that we
> only use this expanded 'waitfor' functionality for the protocols that
> actually support it.

Okay, here's a first rough patch that shows a little what I had in mind. It
should be improved and cleaned up, and I didn't even test it with SFTP or
anything - I just ran a few hundred test cases that seemed to all work fine
still.

-- 
  / daniel.haxx.se

Received on 2009-08-21