cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: "100% CPU usage during SFTP transfer" bugfix

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Fri, 21 Aug 2009 12:56:13 +0200 (CEST)

On Fri, 21 Aug 2009, Kamil Dudka wrote:

>> I'll need to go back to staring at that code for a while more before I take
>> a stab at this. If anyone else does it first, by all means go ahead!
>
> I am still a bit new to libcurl and not yet familiar with its design. What
> about not making 'waitfor' as ssh-specific? Then its value can be checked
> within Curl_readwrite() and performed the appropriate poll if necessary, not
> sure how is the situation with other protocols...

Yes, that's along my line of thinking. We must of course make sure that we
only use this expanded 'waitfor' functionality for the protocols that actually
support it.

It would also provide a foundation to fix the problem with OpenSSL code and
the returned WANT codes that we discussed the other day.

-- 
  / daniel.haxx.se
Received on 2009-08-21