cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: debugging a crash in Curl_pgrsTime/checkPendPipeline?

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 12 Aug 2009 10:57:32 +0200 (CEST)

On Tue, 11 Aug 2009, johansen_at_sun.com wrote:

> In transfer.c there's a routine called Curl_retry_request() that checks a
> bunch of other counters about the request before returning a boolean value
> about whether it's safe to retry the connection or not. It looks to me like
> Curl_do() should either be calling this code, or performing similar checks
> on the amount of data transferred.

Yes. I think you're right. The Curl_do() function simply does some assumptions
that might not always be correct.

In fact, since this Curl_retry_request() function is called when Transfer()
fails (in transfer.c) and then does the necessary attempt-to-start-over magic,
I wonder if perhaps that retry logic in Curl_do() is entirely superfluous... I
fear that we don't have any very reliable test cases for those checks so it'll
be hard to tell exactly.

-- 
  / daniel.haxx.se
Received on 2009-08-12