cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: sukender: curl/tests/libtest CMakeLists.txt,NONE,1.1

From: Sukender <suky0001_at_free.fr>
Date: Thu, 09 Apr 2009 00:21:36 +0200

Piotr Dobrogost wrote:
> Sukender wrote:
>
>> And another little question: What, in plain english, means the
>> definition of "CURL_HIDDEN_SYMBOLS"? Is it "Hide some symbols" or
>> "Activate some symbols that are hidden otherwise"? Because lib558.c reads
>> #if !defined(CURL_HIDDEN_SYMBOLS)
>> and then uses symbols like Curl_hash_destroy(). I thought it was the
>> opposite...
>
> For the same reason I propose to change
>
> CMAKE_CXX_STANDARD_LIBRARIES_INIT and CMAKE_C_STANDARD_LIBRARIES_INIT
> in CMakeLists.txt
> to
> CMAKE_CXX_STANDARD_LIBRARIES_ORIGINAL and
> CMAKE_C_STANDARD_LIBRARIES_ORIGINAL
> or
> CMAKE_CXX_STANDARD_LIBRARIES_INITAL and CMAKE_C_STANDARD_LIBRARIES_INITIAL
>
> as the word init is used often as a verb and in this case this
> abbreviation is misleading a little bit.
>
>

Done!

-- 
Sukender
PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/
Received on 2009-04-09