cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: [PATCH] Colon in username

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 25 Sep 2008 13:56:33 +0200 (CEST)

Igor Novoseltsev wrote:

(I accidentally deleted the original mail so please excuse me for
handicrafting the reply and thus not being properly threaded.)

> Could you review and adopt the proposed patch for Known Issue #7 ?

> This patch adds two new options to the curl_easy_setopt() interface:
> CURLOPT_USERNAME and CURLOPT_PASSWORD.

Great, thanks! I have two comments basically:

1 - If accepted, it will be targeted for 7.19.1 as that's the next release
     version number

2 - These options remove the restriction that colons can't be in the user name
     provided with the CURLOPT_USERPWD option. But this made me consider what
     restrictions they don't remove and I came to think of the ability to use
     binary zeroes in the user name and/or password. While I'm not exactly sure
     right now about which protocols that might not like this and which that
     do, I think I would prefer a way that allows *ALL* 256 different byte
     values in all positions of the user name and password. (Even if I'm sure
     that libcurl internally can't deal with binary zeroes in either field
     right now.)

     So what about instead accept these fields URL encoded? Then you could do
     really wild usernames like %00:%41:%ff with no problems...

What do you (all you reading this) think?

-- 
  / daniel.haxx.se
Received on 2008-09-25