cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: OS/400 config/setup minor reordering patch

From: Yang Tse <yangsita_at_gmail.com>
Date: Mon, 21 Jul 2008 20:47:27 +0200

2008/7/21, Patrick Monnerat wrote:

> I just tested it: it compiles fine and runs too.
> However I did it the way it is now to keep regular autoconf things
> (although I do not have autoconf on OS400) in config-os400.h and other
> machine barbarisms into the setup-os400.h file.
>
> > Ok to commit ?
> I do not see what it improves, but if you think it does so, I'm OK !

Certainly true at this point.

It clears the way for the 64-bit curl_off_t patch, otherwise something
like this would need to be included in the 64-bit curl_off_t patch.

As a matter of fact, the only part of current setup-os400.h that would
need to be moved into config-os400.h would be those definitions that
_must_ be done before any system header is included. Not sure if I
have moved too much with this patch. I simply read current comment.
Maybe there's no need to move all the stuff I've moved.

If you wish to trim it. Simply take in account that the 64-bit
curl_off_t patch will/might include system headers in setup.h between
the points where config-os400.h and setup-os400.h would be included.

Regards,

-- 
-=[Yang]=-
Received on 2008-07-21