cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: These test cases failed: 613 614

From: Daniel Johnson <daniel_at_daniel-johnson.org>
Date: Sun, 15 Jul 2007 08:29:22 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Jul 14, 2007, at 11:42 AM, James Housley wrote:

> On Jul 14, 2007, at 10:21 AM, Guenter Knauf wrote:
>
>
>> Hi,
>> I did yesterday again update my autobuild box to latest libssh2
>> CVS code cause I thought I could fix the occationally failing test
>> 601; it seems that this fixed it, however now I get permanently
>> fails with these:
>> TESTFAIL: These test cases failed: 613 614
>> also Daniel Johnson's autobuilds have same fails....
>>
>
> This was talked about in a thread called "Last sftp commit may
> break test 613 and 614" that was started on July 10th. The problem
> is the newest versions of libssh2 return directories in a different
> format then the older versions, it is capable of showing the
> username and group as text instead of numeric. The format of that
> is dependent on the OS you are connecting to. And I the perl for
> checking the test results is using Perl that is beyond my basic
> understanding of the language.
>

Just to add more information, while 613 and 614 are failing for me,
I'm using libssh2 0.15, not the latest CVS. Also during those tests
curl is actually *crashing* rather than the test simply failing. This
is my crash log:

Exception: EXC_BAD_ACCESS (0x0001)
Codes: KERN_PROTECTION_FAILURE (0x0002) at 0x0006dacc

Thread 0 Crashed:
0 libSystem.B.dylib 0x90109cd6 memset + 134
1 libcurl.4.dylib 0x0021a842 Curl_safefree + 47 (url.c:211)
2 libcurl.4.dylib 0x0024585f ssh_statemach_act + 13270 (ssh.c:1690)
3 libcurl.4.dylib 0x00245d1f ssh_easy_statemach + 37 (ssh.c:1853)
4 libcurl.4.dylib 0x00245f9a scp_perform + 117 (ssh.c:2235)
5 libcurl.4.dylib 0x00246100 Curl_scp_do + 211 (ssh.c:2290)
6 libcurl.4.dylib 0x0022163c Curl_do + 96 (url.c:4313)
7 libcurl.4.dylib 0x0022fb2c Curl_perform + 192 (transfer.c:2425)
8 libcurl.4.dylib 0x00230372 curl_easy_perform + 251 (easy.c:498)
9 curl 0x0000a3d0 operate + 11932 (main.c:4383)
10 curl 0x0000aceb main + 98 (main.c:4690)
11 curl 0x00001e06 _start + 216
12 curl 0x00001d2d start + 41

It looks like libssh2_session_last_error at ssh.c line 1685 is
specifying want_buf = 0, but according to libssh2 "If want_buf is non-
zero then the string placed into errmsg must be freed by the calling
program. Otherwise it is assumed to be owned by libssh2." So curl
shouldn't be calling Curl_safefree on err_msg.

Daniel Johnson

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (Darwin)
Comment: http://homepage.mac.com/danielj7/publickey.txt

iD8DBQFGmhMi4sDFGYouOqARAuNnAKCOqd+9EfLygBVCrqggHnbZg5yYMgCeOvOc
/XXkoCOZTuv60o6ZCcQTtgA=
=5/vC
-----END PGP SIGNATURE-----
Received on 2007-07-15