-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Jul 2, 2007, at 5:12 PM, Daniel Stenberg wrote:

> On Mon, 2 Jul 2007, Thomas J. Moore wrote:
>
>
>> Thanks. I checked out the CVS this morning and tried it with
>> clear, safe, and private (krb5), and it seems to work fine. I've
>> never tried confidential (and therefore doubt it works), because
>> the MIT ftpd doesn't seem to support it. It may work for krb4,
>> though. I've also not tried krb4, since I'm not sure how to set
>> up a test case.
>>
>
> Thanks for verifying! I don't know of anyone who uses or can test
> krb4 so it probably already was broken and I don't think we broke
> it too much more with this change...
>

I've started getting compiler warnings in my autobuilds due to the
new code:

../../curl/lib/security.c: In function 'sec_send':
../../curl/lib/security.c:258: warning: passing argument 2 of
'block_write' discards qualifiers from pointer target type
../../curl/lib/security.c:260: warning: passing argument 2 of
'block_write' discards qualifiers from pointer target type
../../curl/lib/security.c:262: warning: passing argument 2 of
'block_write' discards qualifiers from pointer target type

This is due to const string literals being passed to the non-const
second parameter of block_write.

There are also unused variables and parameters in krb5.c:

../../curl/lib/krb5.c: In function 'krb5_check_prot':
../../curl/lib/krb5.c:81: warning: unused variable 'context'
../../curl/lib/krb5.c: At top level:
../../curl/lib/krb5.c:89: warning: unused parameter 'level'
../../curl/lib/krb5.c:90: warning: unused parameter 'conn'
../../curl/lib/krb5.c: In function 'krb5_overhead':
../../curl/lib/krb5.c:115: warning: unused variable 'context'
../../curl/lib/krb5.c: At top level:
../../curl/lib/krb5.c:125: warning: unused parameter 'conn'
../../curl/lib/krb5.c: In function 'krb5_auth':
../../curl/lib/krb5.c:160: warning: unused variable 'cs'
../../curl/lib/krb5.c:159: warning: unused variable 'len'
../../curl/lib/krb5.c:158: warning: unused variable 'ptr'

Daniel Johnson

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (Darwin)
Comment: http://homepage.mac.com/danielj7/publickey.txt

iD8DBQFGjUiy4sDFGYouOqARAkcDAJ44sOFdJR7wslbvHFIkpEcnRPpuFwCfezn0
TRY43Ios+og6mnoYJdYVidU=
=u3oJ
-----END PGP SIGNATURE-----
Received on 2007-07-05