On Jun 26, 2007, at 3:46 PM, Daniel Stenberg wrote:

> On Tue, 26 Jun 2007, cvs_at_labb.contactor.se wrote:
>
>> if (data->set.ftp_list_only) {
>> - if ((attrs.flags & LIBSSH2_SFTP_ATTR_PERMISSIONS) &&
>> - ((attrs.permissions & LIBSSH2_SFTP_S_IFMT) ==
>> - LIBSSH2_SFTP_S_IFDIR)) {
>> - infof(data, "%s\n", filename);
>> - }
>> + infof(data, "%s\n", filename);
>
> I think this is a case where the data should rather be passed to
> the apps' write callback and not just be passed as "debug info"
> with infof(). Since the app has asked for a directory listing, I
> bet it wants it delivered using the regular means (write callback).

Okay, coming right up.

Jim

--
/"\   ASCII Ribbon Campaign  .
\ / - NO HTML/RTF in e-mail  .
  X  - NO Word docs in e-mail .
/ \ -----------------------------------------------------------------
                      http://www.FreeBSD.org     The Power to Serve
jim@TheHousleys.Net  http://www.TheHousleys.net
---------------------------------------------------------------------
In theory there is no difference between theory and practice.
In practice there is no similarity.
       -- From the "I wish I'd said that" archives.