cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: jehousley: curl/lib ssh.c,1.53,1.54

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Tue, 26 Jun 2007 21:46:55 +0200 (CEST)

On Tue, 26 Jun 2007, cvs_at_labb.contactor.se wrote:

> if (data->set.ftp_list_only) {
> - if ((attrs.flags & LIBSSH2_SFTP_ATTR_PERMISSIONS) &&
> - ((attrs.permissions & LIBSSH2_SFTP_S_IFMT) ==
> - LIBSSH2_SFTP_S_IFDIR)) {
> - infof(data, "%s\n", filename);
> - }
> + infof(data, "%s\n", filename);

I think this is a case where the data should rather be passed to the apps'
write callback and not just be passed as "debug info" with infof(). Since the
app has asked for a directory listing, I bet it wants it delivered using the
regular means (write callback).

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2007-06-26