On Jun 20, 2007, at 4:35 AM, Daniel Stenberg wrote:

> On Tue, 19 Jun 2007, James Bursa wrote:
>
>>> If either fail, then public key authentication is not used. Both
>>> are freed and the state machine moves on to password authentication.
>>
>> I would find the behaviour silently changing when out of memory
>> surprising. I think it would be better if it would return an error:
>>
>> state(conn, SSH_SESSION_FREE);
>> sshc->actualCode = CURLE_OUT_OF_MEMORY;
>
> I think I agree. If you asked for public key auth, you really
> rather have that fail than just have it disabled due to memory
> problems.

Change is being made. I thought it would be good to keep trying the
connection and not abort on a single problem. However, in reality if
there was a memory failure here it is unlikely to continue too far
before it gets another.

Jim

--
/"\   ASCII Ribbon Campaign  .
\ / - NO HTML/RTF in e-mail  .
  X  - NO Word docs in e-mail .
/ \ -----------------------------------------------------------------
                      http://www.FreeBSD.org     The Power to Serve
jim@TheHousleys.Net  http://www.TheHousleys.net
---------------------------------------------------------------------
The wise man built his network upon Un*x.
     The foolish man built his network upon Windows.