cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: PATH_MAX

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 20 Jun 2007 10:35:14 +0200 (CEST)

On Tue, 19 Jun 2007, James Bursa wrote:

>> If either fail, then public key authentication is not used. Both are freed
>> and the state machine moves on to password authentication.
>
> I would find the behaviour silently changing when out of memory surprising.
> I think it would be better if it would return an error:
>
> state(conn, SSH_SESSION_FREE);
> sshc->actualCode = CURLE_OUT_OF_MEMORY;

I think I agree. If you asked for public key auth, you really rather have that
fail than just have it disabled due to memory problems.

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html
Received on 2007-06-20