curl-library
Re: [PATCH] - master_buffer alloc only on pipelining set on
Date: Sun, 22 Apr 2007 13:24:41 +0300
On 4/22/07, Daniel Stenberg <daniel_at_haxx.se> wrote:
> On Sat, 21 Apr 2007, Robert Iakobashvili wrote:
>
> > Now, hopefully, the correct patch. Passes libcurl tests, pipelining tested
> > against lighttpd server.
> >
> > Still, not sure, if mainstream neads it, but embedded people may like it.
>
> I'm all for not using more memory than required.
>
> But your patch fails test 530 for me:
>
> test 530...[HTTP GET using pipelining]
>
> ** MEMORY FAILURE
> Leak detected: memory still allocated: 49152 bytes
> At 49834f4, there's 16384 bytes.
> allocated by url.c:2843
> At 497ed2c, there's 16384 bytes.
> allocated by url.c:2843
> At 497a564, there's 16384 bytes.
> allocated by url.c:2843
It took time to realize, that for mem analyzes it requires
--enable-debug configuration.
:)
Indeed, a memory leak fixed, see the attached.
-- Sincerely, Robert Iakobashvili, coroberti %x40 gmail %x2e com ................................................................... Navigare necesse est, vivere non est necesse ................................................................... http://curl-loader.sourceforge.net An open-source HTTP/S, FTP/S traffic generating, and web testing tool.
- text/x-patch attachment: curl-alloc-master-buffer.patch