cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: Misc. SSH improvement patch

From: Nick Zitzmann <nick_at_chronosnet.com>
Date: Wed, 4 Apr 2007 16:02:03 -0600

On Apr 4, 2007, at 3:13 PM, Daniel Stenberg wrote:

> 2. calls libssh2_error_to_CURLE() to get a CURLcode out from it,
> but that
> function gets a different error code from libssh2 since it will
> use
> libssh2_session_last_error() and not libssh2_sftp_last_error() !
>
> My suggestion is that we modify libssh2_error_to_CURLE() to take
> the libssh2 error code as an argument instead. What do you say
> about that? We can probably also remove the infof() from within
> that function.

Ah, I overlooked that one.

I dug a little deeper and it looks like the SFTP errors and session
errors use conflicting codes, so we're going to need two translation
functions, one for the SSH session and one specifically for SFTP.

Nick Zitzmann
<http://www.chronosnet.com/>
Received on 2007-04-05