cURL / Mailing Lists / curl-library / Single Mail

curl-library

RE: usage CURLOPT_TIMECONDITION with Upload FTP

From: <christophe.legry_at_orsyp.com>
Date: Tue, 5 Apr 2005 17:20:47 +0200

Thanks for your suggestion,
I modified code only for check if 'ftp->no_transfer' is not TRUE

The update for file ftp.c and relates to the function :
CURLcode Curl_ftp_done(struct connectdata *conn, CURLcode status)
(start at line 825 in 7-13-0 version)

C.L.

-----Message d'origine-----
De : curl-library-bounces_at_cool.haxx.se
[mailto:curl-library-bounces_at_cool.haxx.se]De la part de Daniel Stenberg
Envoyé : mardi 5 avril 2005 12:44
À : libcurl development
Objet : RE: usage CURLOPT_TIMECONDITION with Upload FTP

On Tue, 5 Apr 2005 christophe.legry_at_orsyp.com wrote:

> I added the modified source file ftp.c. (line 2225)

Thanks!

Please provide patches with 'diff -u'. It would've saved us some 120KB to each
subscriber.

Also, the fix is not really fine. Setting infilesize to -1 may be what
prevents an error to appear for you, but it also changes the variable
internally and thus if you try the same upload again on the same handle the
app will have to reset the filesize and that is not the intended nor the
documented behaviour of easy handle options.

I suggest you instead make the fix to check for if 'ftp->no_transfer' is TRUE
and if so avoid the error message about failed upload.

-- 
  Commercial curl and libcurl Technical Support: http://haxx.se/curl.html

Received on 2005-04-05