Hi,

The patch is good:
1. Debug information is readable for source and target.
2. Relative path in target can be used.

Using CURLOPT_FTPPORT for regular (target) URL and PORT for SOURCE_URL
seems good.
About IPv6: when I have changed the code I didn't find a way to reuse
all the functionality of IPv6 and SSL support. The code was not modular
at all. As you should remember, I did some decoupling by taken out some
code to separate functions for reuse. I think that for IPv6 and SSL
support the same approach should be considered.

Alexander K.

-----Original Message-----
From: curl-library-bounces_at_cool.haxx.se
[mailto:curl-library-bounces_at_cool.haxx.se] On Behalf Of Daniel Stenberg
Sent: Monday, January 17, 2005 17:00
To: libcurl development
Subject: RE: more 3rd party stuff

On Mon, 17 Jan 2005, Alexander Krasnostavsky wrote:

(Attached the current work in progress patch for the 3rd party transfer)

> OK. In what version it will apply?

I want all this 3rd party stuff to be fixed and work in the current
7.12.X
code. My rewrite will then be made to work the same way.

My rewrite may take a considerable time to complete.

> Still you will need the SOURCE_PORT, PREQUOTE and POSTQUOTE, am I
right?

Almost.

It would be SOURCE_URL (which would be a single option instead of
separate
HOST, PATH and PORT options), SOURCE_QUOTE (which doesn't exist today),
SOURCE_PREQUOTE, SOURCE_POSTQUOTE. I think it would still make since to
have
SOURCE_USERPWD to match the plain USERPWD option.

Regarding PASV_HOST, I think we can instead let the standard
CURLOPT_FTPPORT
option control that. If CURLOPT_FTPPORT is set to something non-NULL, it
would make the regular URL (which is the target one) use PORT, otherwise
it would use PASV. What would you say about that?

And a related note: libcurl is IPv6-capable. The 3rd party support is
not. It should rather use EPSV before PASV, and EPRT and LPRT before
PORT... Like the regular FTP transfers do.

--
      Daniel Stenberg -- http://curl.haxx.se -- http://daniel.haxx.se
       Dedicated custom curl help for hire: http://haxx.se/curl.html

The information contained in this message is proprietary of Amdocs,
protected from disclosure, and may be privileged.
The information is intended to be conveyed only to the designated recipient(s)
of the message. If the reader of this message is not the intended recipient,
you are hereby notified that any dissemination, use, distribution or copying of
this communication is strictly prohibited and may be unlawful.
If you have received this communication in error, please notify us immediately
by replying to the message and deleting it from your computer.
Thank you.
Received on 2005-01-19