curl-library
Re: Creating missing dirs for FTP third party transfer.
From: Daniel Stenberg <daniel-curl_at_haxx.se>
Date: Mon, 11 Oct 2004 20:12:19 +0200 (CEST)
Date: Mon, 11 Oct 2004 20:12:19 +0200 (CEST)
On Mon, 11 Oct 2004, Alexander Krasnostavsky wrote:
> The attached patch implements creating missing dirs option in case of FTP
> third party transfer.
Thanks, but I have a remark about it first:
ftp_make_path() is a misleading name, as it not only makes a path, it also
changes to the directory (given in the URL). I also believe your patch bugs if
you re-use a connection since you're using the same 'entrypath' on both
servers and I fail to see how that can be right, can you? (The function
changes to that dir first, to start over from the same place between multiple
requests.)
I think this is just another example where a few test cases would've been very
valuable.
-- Daniel Stenberg -- http://curl.haxx.se -- http://daniel.haxx.se Dedicated custom curl help for hire: http://haxx.se/curl.htmlReceived on 2004-10-11