codemastr wrote:
>>I don't know about every OS, but it is POSIX, and works on the systems I
>>have here (Linux, FreeBSD and Solaris).
>>
>>I looked at the autoconf docs again but couldn't find a test for
>>specific defines like this. If there is one I'd agree that we should use
>>it.
>
> Well Windows does support it as well. I'm just wondering more about some of
> the less-common OSes (IRIX, VMS, etc.)
>
> I did some googling, and I found a change log for Apache (1.2.5) and it
> says:
> *) Don't disable Nagle algorithm if system doesn't have TCP_NODELAY.
> [Marc Slemko and Roy Fielding]
>
> So that to me makes it sound like there are some OSes that do not support
> this.
>
> But really, I don't see any need for an autoconf check. Just enclose the
> code in #ifdef TCP_NODELAY. If that is defined, then TCP_NODELAY exists. If
> it is not defined, then TCP_NODELAY does not exist. That seems like a
> workable solution to me...

Duhh. I guess that would be the obvious thing. I'm having a bad day
today, sorry. I'll redo and submit another patch.

Joe
Received on 2004-03-21