cURL / Mailing Lists / curl-library / Single Mail

curl-library

Re: PATH: CURLOPT_FTP_CREATE_MISSING_DIRECTORIES

From: Early Ehlinger <early_at_respower.com>
Date: Thu, 7 Aug 2003 15:23:35 -0500

Thanks for merging this in! I'll be checking CVS to find it later. I
really believe that this is a valuable new feature for libcURL and hope that
somebody else down the line benefits from my efforts just as I've benefitted
from yours.

Thanks also for helping me implement it correctly, as opposed to hardcoding
the functionality in place..., and for helping me look at the ./configure
stuff a few days ago. I'm hoping to get back on that horse soon and have
./configure working with MinGW/MinSYS, time permitting of course. Don't be
surprised to hear me asking some questions :)

And finally, thanks for pointing out my newbie mistakes without being rude
about it! I can't tell you how many times I've tried to get into the
open-source fray and been treated like an idiot for not spending months on
researching the proper way to create a patch for something that took an hour
to write. I'm sure my lack of experience with your build process has slowed
you down some (as evidenced below) and I really do appreciate your patience.

"Daniel Stenberg" <daniel_at_haxx.se> wrote:
> 1. Please append all changes into one single patch file and attach that as
a
> plain text file. It makes it a lot faster and easier to read.

Erm (exposing newbieness yet again) - How exactly does one do that? Any
links? Or do I just cat all of the .diff files together into one?

> 2. Do not use tabs in the source code (since all users seem to set their
> editors to use different withs), do not use // comments and don't mix
> variable declarations and code since that is not portable enough.

Didn't intend to use any tabs - damnable emacs! I thought I had turned them
off! Grrr...

Sorry about the // and inline variable declarations - I'm normally a C++ guy
and those differences with ANSI C are the hardest C++ habits to break...
Maybe I need to alter makefile.m32 to force gcc to catch these mistakes...

Thanks again for incorporating these changes!

--
-- Early Ehlinger CEO, ResPower Inc - Toll-Free : 866-737-7697
-- www.respower.com -- 500+ GHz Supercomputer Starting At USD$0.50/GHz*Hour
-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
Received on 2003-08-07