Oleg Pudeyev" <oleg+pycurl_at_bsdpower.com> wrote:

> My libcurl.lib name appears to come from here:
>
> https://github.com/bagder/curl/blob/master/winbuild/MakefileBuild.vc#L79

Okay, I see. This doesn't follow the FAQ.

> won't work. However, I don't doubt what you say holds for your system,
> therefore here is my proposed solution:
>
> https://github.com/pycurl/pycurl/pull/92
>
> You would give --curl-lib-name=libcurl_imp.lib --use-curl-dll options.

Seems okay. How about adding a '--help' option to setup.py?

But the logic seems a bit backward. Not giving a '--use-curl-dll' should
IMHO add a:
 extra_compile_args.append("-DCURL_STATICLIB=1")

I.e. remove the "#define CURL_STATICLIB 1" in pycurl.c. Thus
CURL_EXTERN becomes __declspec(dllimport) in <curl/curl.h>

BTW.
  the statement ' add_libdirs("LIB", ";")' is superfluous. The linker
  already uses %LIB to search for .lib-files.

Which brings up my idea to add a 'add_include_dirs("INCLUDE",";")' to
search for "curl/curl.h" and figure out the 'curl_dir' from that before calling
'fail()'.

>> BTW. pycurl_inet_ntop() didn't compile. A patch:
>
> Thanks, https://github.com/pycurl/pycurl/pull/91.

Looks okay.

--gv
_______________________________________________
http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-and-python
Received on 2013-12-19