curl-and-python
Re: [PATCH] Support curl-7.19.6 SSH_KNOWNHOSTS and SSH_KEYFUNCTION in pycurl
Date: Mon, 18 Oct 2010 14:46:56 -0400
Hey Gary i'm just pinging this if you aren't able or would like for me
to do so I will do this tonight/tomorrow sometime if possible.
On Tue, Oct 12, 2010 at 1:28 PM, Christopher Warner
<cwarner_at_kernelcode.com> wrote:
> On Tue, Oct 12, 2010 at 12:54 PM, Gary V. Vaughan <gary_at_gnu.org> wrote:
>> Hi Christopher,
>>
>> Wow, I'd almost forgotten about that patch it's been so long ;)
>>
>> Thanks for chasing it up for me though. And especially for digging
>> out that slightly obscure email address to contact me about it -
>> the whole of thewrittenword.com has been down for a couple of days
>> due to AC failure.
>
> Yeah sorry about that, was trying to hunt you down by any means
> necessary. I sent a ping via twitter as well should you get that.
>
>> On 12 Oct 2010, at 23:36, Christopher Warner wrote:
>>> I'm now looking at this patch and didn't see any old discussion on why
>>> this was not accepted Gary besides not finding it on the Pycurl list.
>>> I apologize it has taking this long for someone to get back to you.
>>
>> No problem, at least it didn't fall through the cracks entirely :)
>>
>>> A couple of things. I'm not a fan of having base64_encode in here, it
>>> just quite frankly does not belong in this module. That's a gripe of a
>>> different sort at this point.
>>
>> No, me neither, but it was the easiest way to get the patch working,
>> and I wasn't sure what alternative would be preferred.
>
> Yeah right now I want to reorganize a couple of things which I will be
> doing in the github branch.
>
>>> The const below needs cleaning up i've added corrections via + but the
>>> patch will need to be resubmitted against the sourceforge cvs branch
>>> of PyCurl. Otherwise I'd like to put this into the branch of pycurl
>>> i'm working on here http://github.com/christophwarner/PyCurl/tree/2010
>>> After some testing and reorganization I will commit.
>>
>> I'm not sure I understand. Are you asking for me to rebase my original
>> patch against upstream? Or volunteering to do that for me via your
>> github mirror?
>>
>
> Rebase against upstream in sourceforge cvs and submit, as some changes
> have taken place since you've done so last most likely. I plan for
> reorganization and severe breakage to go on in the github branch while
> I'm applying and working stuff and I don't want to hold up useful
> patches that others may be able to use in the interim.
>
> Thanks by the way for the quick response :)
>
> --
> Christopher Warner
> http://cwarner.kernelcode.com
>
-- Christopher Warner http://cwarner.kernelcode.com _______________________________________________ http://cool.haxx.se/cgi-bin/mailman/listinfo/curl-and-pythonReceived on 2010-10-18