On Sun, Nov 16, 2008 at 1:05 PM, Piotr Dobrogost <curlpp_at_2008.autoera.pl>wrote:

> Jean-Philippe Barette-LaPierre wrote:
> >
> > I just commited the structural changes. You can change the VC++ files
> now.
>
> Jean
>
> Thanks a lot for this work.
>
> Below there are some comments from me.
>
> 0. curlpp .cpp files are missing (CurlHandle.cpp, Easy.cpp etc.)

I'll fix that. I don't know why I didn't saw that.

>
> 1. Copyright notice is not updated to current year.
> 2. Some headers have include guard beginning with CURLPP and some don't
> have this prefix. I think all should have.
> 3. Some headers don't have include guard.
> 4. Some .inl files don't have include guard.
> 5. NonCopyable is in both curlpp and utilspp. Shouldn't we have only one in
> utilspp?
>

Absolutely, NonCopyable should only be in utilspp

>
> If you agree with above I could make these changes.

Alright, but I'll do the missing .cpp files.

>
>
> Regards
> Piotr Dobrogost
> _______________________________________________
> cURLpp mailing list
> cURLpp_at_rrette.com
> http://www.rrette.com/mailman/listinfo/curlpp
>

_______________________________________________
cURLpp mailing list
cURLpp_at_rrette.com
http://www.rrette.com/mailman/listinfo/curlpp
Received on 2008-11-16