On 2014-01-05 17:40, Daniel Stenberg wrote:
> Thanks a lot for this! I've now pushed this patch to git.
>
> Can you take a look at updating the docs/mk-ca-bundle.1 file too with
details about this new option?

Started when asked, but got sick for a while and had to recover.

Had to familiarize myself with basic man page formatting syntax as it's
been a while. Installed CygWin and the man page tools to help get started.

Couple questions about changes to code:

First:

In mk-ca-bundle.pl there was unused function:

sub VERSION_MESSAGE() {
   print "${0} version ${version} running Perl ${]} on ${^O}\n";
}

Help listing -i shows version info:

   print "\t-i\tprint version info about used modules\n";

The version info was specified with a conditional check of $opt_i .

if ($opt_i) {
   print "lots of stuff ...\n";
}

Thinking I'd like to simplify. Move contents of the $opt_i conditional
to the VERSION_MESSAGE function, call that function in $opt_i
conditional. Similar to the way HELP_MESSAGE and WARNING_MESSAGE are
handled.

WARNING_MESSAGE() unless ($opt_q || $url =~ m/^(ht|f)tps:/i );
HELP_MESSAGE() if ($opt_h);

Second:

I am fixing man page, to add info about the new -d option. Noticed
other minor spelling, spacing and formatting issues. Must I submit
individual patches, or is it simple enough for one patch?

Third:

Wondering if it would be easier to maintain the manual page from a Perl
Pod? Plain Old Documentation, can all go at the end, or also inline.
Tools podchecker and pod2man included with Perl.

Fourth:

Have not forgotten about the .vbs script. When the .pl changes are all
settled, I can update the .vbs. Easy enough to figure out and test.

Leif

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-users
FAQ: http://curl.haxx.se/docs/faq.html
Etiquette: http://curl.haxx.se/mail/etiquette.html
Received on 2014-01-21