On Wed, 3 Jul 2013, Markus Moeller wrote:

> Thank you . Fixed it.

Thanks a lot for this work! Here follow my first review comments:

1 - this should be posted to curl-library instead to get more and proper eyes
     on the patch. I've Cc'ed this reply to that list, please take follow-ups
     there! (For new readers: I'm replying to
     http://curl.haxx.se/mail/archive-2013-07/0008.html )

2 - Doesn't this patch alter the default behavior if none of these options are
     used? That logic that selects KHTTP or HTTP seems to be just removed, or
     did I misunderstand?

3 - The two defines CURL_DEFAULT_*NEGOTIATE_GSSAPI_SERVICE are defined but
     never used?

4 - It causes compiler warnings for me against current git master:

http_negotiate.c:109:3: error: passing argument 1 of 'Curl_infof' from
incompatible pointer type [-Werror]
    infof(&conn->data,"Import Service Name %.*s\n",token.length,token.value);
    ^
In file included from http_negotiate.c:34:0:
sendf.h:29:6: note: expected 'struct SessionHandle *' but argument is of type
'struct SessionHandle **'
  void Curl_infof(struct SessionHandle *, const char *fmt, ...);
       ^
http_negotiate.c:64:25: error: unused variable 'neg_ctx'
[-Werror=unused-variable]
    struct negotiatedata *neg_ctx = proxy?&conn->data->state.proxyneg:
                          ^
5 - It causes checksrc.pl warnings:

../lib/http_negotiate.c:70:87: warning: Longer than 79 columns
    char *serviceptr =
proxy?conn->data->set.str[STRING_PROXY_NEGOTIATE_GSSAPI_SERVICE]:
../lib/http_negotiate_sspi.c:49:87: warning: Longer than 79 columns
    char *serviceptr =
proxy?conn->data->set.str[STRING_PROXY_NEGOTIATE_GSSAPI_SERVICE]:
../lib/http_negotiate_sspi.c:73:3: warning: else after closing brace on same
line
    } else {
    ^
../lib/url.h:76:81: warning: Longer than 79 columns
  #define CURL_DEFAULT_NEGOTIATE_GSSAPI_SERVICE "HTTP" /* default negotiate
gssapi
../lib/url.h:78:93: warning: Longer than 79 columns
  #define CURL_DEFAULT_PROXY_NEGOTIATE_GSSAPI_SERVICE "HTTP" /* default proxy
negotiate gssapi
checksrc: 0 errors and 5 warnings

-- 
  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-users
FAQ:        http://curl.haxx.se/docs/faq.html
Etiquette:  http://curl.haxx.se/mail/etiquette.html