cURL / Mailing Lists / curl-users / Single Mail

curl-users

Re: Metalink support patch for curl

From: Tatsuhiro Tsujikawa <tatsuhiro.t_at_gmail.com>
Date: Thu, 21 Jun 2012 23:52:45 +0900

On Thu, Jun 21, 2012 at 11:28 AM, Yang Tse <yangsita_at_gmail.com> wrote:
> Tatsuhiro Tsujikawa <tatsuhiro.t_at_gmail.com> wrote:
>
>> 0001 patch contains referctoring to reduce memory copy when multiple
>> checksum is provided.
>> 0002 patch contains the changes I mentioned above.
>> 0003 patch restores noprogress and isatty config values in each download.
>> This might be a bug fix.
>> 0004 patch adds Metalink test case. Please forget about my previous
>> mail about Metalink test cases.
>

Thank you very much for merging my patch set!

> Full test suite run with patches 0001 to 0003 applied passed here with
> no failure. Although it took 10% longer to complete, further
> investigation could be interesting.
>

I ran tests several times, but I didn't see much difference between
patched and unpatched sources. Both completed tests around 6 minutes.

> Test case #2005 from 0004 patch massaged.
>
> Pushing all to repo as I write these lines.
>
> For the benefit of scripts parsing curl's stderr It would be
> interesting if all metalink related messages sent to stderr started
> with a common literal such as 'Metalink:'.
>

Agreed. Patch attached.

Best regards,

Tatsuhiro Tsujikawa

> Thanks,
> --
> -=[Yang]=-
> -------------------------------------------------------------------
> List admin: http://cool.haxx.se/list/listinfo/curl-users
> FAQ:        http://curl.haxx.se/docs/faq.html
> Etiquette:  http://curl.haxx.se/mail/etiquette.html

-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-users
FAQ: http://curl.haxx.se/docs/faq.html
Etiquette: http://curl.haxx.se/mail/etiquette.html

Received on 2012-06-21